Passing db_name param to the describeCollection()
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atabase is not passed to `describeCollection` function
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rashgaroth The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @rashgaroth! It looks like this is your first PR to milvus-io/milvus-sdk-node 🎉 |
|
please remove these lock files. |
This reverts commit 9c4d8e5.
done @shanghaikid |
shanghaikid
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Fix "Cannot read properties of undefined reading nq" because of the database is not passed to `describeCollection` function * Delete package-lock.json * Delete yarn.lock * Revert "Delete yarn.lock" This reverts commit 9c4d8e5. * Remove lock files This reverts commit 8315115. * Revert "Remove lock files" This reverts commit 4f23775. * Remove lock files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've got an error when search with the specific db name, the error is :
Cannot read properties of undefined (reading nq), that's because the codeData.tsdoes not passing thedb_nameparameterSummary
This pull request to
milvus/grpc/Data.tsincludes changes to improve the handling of collection requests in thesearchmethod. The most important changes include importing theDescribeCollectionReqtype and modifying thesearchmethod to use a default collection request.Improvements to collection request handling:
milvus/grpc/Data.ts: Added theDescribeCollectionReqimport to support type checking for collection requests.milvus/grpc/Data.ts: Modified thesearchmethod to use a defaultdescribeCollectionRequestobject and conditionally add thedb_nameif present in the request.